-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): rework store for files modal #2745
Conversation
✅ Yeeeehaw, deploy preview is ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Yeeeehaw, deploy preview is ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
1e6635e
to
fe73340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not impact chat messages |
if doesn't impact chat messages, why the difference in behavior above? @josephmcg |
I would suggest getting the latest rebased branch and running it locally, they're not my changes so I have no idea why chat is acting like that |
seems like our netlify pipeline takes commits from everywhere? idk, i never use it besides mobile testing. that would support the 'someone else's code' theory. |
the netlify commits are the ones on this branch, it takes this branch code changes and then deploys to netlify but I can test locally as well |
checked locally and now is fine and has the same behavior in both dev and this branch thanks for checking 🔨 |
What this PR does 📖
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤